You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not depending on ubuntu-22.04, but I use this more or less as a placeholder OS to build the ARM targets. The alternative I considered was to build the ARM targets when matrix.os = 'ubuntu-latest', i.e., when the regular Linux target is built. But I thought that having the ARM targets built separately makes more sense. Unfortunately, however, there was no obvious and easy way (at least I can't see it) to achieve this using the current build chain.
ok I think then we should make it use ubuntu-latest. you can always make this a separate step entirely or introduce another variable into the matrix build to check for. lets not misuse a pinned os version for it. this otherwise looks like a specific intent (like I thought in this case)
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1343.
It changes the following:
As now code was changed, no tests beyond executing the binary are needed.